Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle missing remaining balance #120

Merged
merged 5 commits into from
Jun 21, 2023
Merged

Handle missing remaining balance #120

merged 5 commits into from
Jun 21, 2023

Conversation

NiallRees
Copy link
Member

No description provided.

@NiallRees NiallRees had a problem deploying to Approve Integration Tests June 21, 2023 19:57 — with GitHub Actions Failure
@NiallRees NiallRees had a problem deploying to Approve Integration Tests June 21, 2023 19:57 — with GitHub Actions Failure
@NiallRees NiallRees had a problem deploying to Approve Integration Tests June 21, 2023 19:57 — with GitHub Actions Failure
@NiallRees NiallRees had a problem deploying to Approve Integration Tests June 21, 2023 19:57 — with GitHub Actions Failure
@NiallRees NiallRees had a problem deploying to Approve Integration Tests June 21, 2023 21:16 — with GitHub Actions Failure
@NiallRees NiallRees temporarily deployed to Approve Integration Tests June 21, 2023 21:16 — with GitHub Actions Inactive
@NiallRees NiallRees had a problem deploying to Approve Integration Tests June 21, 2023 21:18 — with GitHub Actions Failure
@NiallRees NiallRees temporarily deployed to Approve Integration Tests June 21, 2023 21:18 — with GitHub Actions Inactive
@NiallRees NiallRees force-pushed the handle_missing_remaining_balance branch from 61f1494 to a0f2b9e Compare June 21, 2023 21:39
@NiallRees NiallRees temporarily deployed to Approve Integration Tests June 21, 2023 21:39 — with GitHub Actions Inactive
@NiallRees NiallRees had a problem deploying to Approve Integration Tests June 21, 2023 21:39 — with GitHub Actions Failure
@NiallRees NiallRees force-pushed the handle_missing_remaining_balance branch from a0f2b9e to b8d3a6d Compare June 21, 2023 21:44
@NiallRees NiallRees temporarily deployed to Approve Integration Tests June 21, 2023 21:44 — with GitHub Actions Inactive
@NiallRees NiallRees temporarily deployed to Approve Integration Tests June 21, 2023 21:44 — with GitHub Actions Inactive
ian-whitestone
ian-whitestone approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@ian-whitestone ian-whitestone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to ship once we add the coalesce(...,false) as _is_account_inoverage logic

@NiallRees NiallRees temporarily deployed to Approve Integration Tests June 21, 2023 22:36 — with GitHub Actions Inactive
@NiallRees NiallRees temporarily deployed to Approve Integration Tests June 21, 2023 22:36 — with GitHub Actions Inactive
@NiallRees NiallRees merged commit 644ce23 into main Jun 21, 2023
@NiallRees NiallRees deleted the handle_missing_remaining_balance branch June 21, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ian-whitestone ian-whitestone ian-whitestone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NiallRees @ian-whitestone